Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone workflow #855
Standalone workflow #855
Changes from all commits
8e8cf9c
50718ce
0a22e23
bf51d2c
ff71dbd
79ee035
8ac3be9
5e42a19
aded976
2e00dc5
4652dc7
9f2aca7
4c9648b
f6641f1
c4adf04
7ceed88
1ff74c7
dd8090b
3db1647
1e82bcd
8110d41
ccb585a
efae588
3544e99
eb921f4
c855e94
0101e50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this commented code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of unnecessary copy-past. Matrix strategy support structured variables, so in the matrix runtime enumeration add
suffix
of the desired checksum file and unify these three steps:See the example in https://github.com/nspcc-dev/neo-go/blob/b028c772f2c592a22796484dfab8f848ca8ed2de/.github/workflows/build.yml#L40.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same optimisation may be done with uploading steps.