add gas price to artifact #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Oct 23, 2024
shargon
reviewed
Oct 23, 2024
tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Recursion.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Array.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_ComplexAssign.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Enum.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Foreach.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Linq.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Out.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Record.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Recursion.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Reentrancy.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Returns.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Stack.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Syscall_Out.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Tuple.cs # tests/Neo.SmartContract.Template.UnitTests/templates/neocontractnep17/TestingArtifacts/Nep17ContractTemplate.artifacts.cs # tests/Neo.SmartContract.Template.UnitTests/templates/neocontractowner/TestingArtifacts/OwnableTemplate.artifacts.cs
shargon
reviewed
Oct 23, 2024
tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Assignment.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Array.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_ComplexAssign.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Enum.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Foreach.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Linq.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Out.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Record.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Recursion.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Reentrancy.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Returns.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Stack.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Syscall_Out.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Tuple.cs # tests/Neo.SmartContract.Template.UnitTests/templates/neocontractnep17/TestingArtifacts/Nep17ContractTemplate.artifacts.cs # tests/Neo.SmartContract.Template.UnitTests/templates/neocontractowner/TestingArtifacts/OwnableTemplate.artifacts.cs
# Conflicts: # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Array.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_ComplexAssign.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Enum.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Foreach.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Linq.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Out.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Record.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Recursion.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Reentrancy.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Returns.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Stack.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Syscall_Out.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Tuple.cs # tests/Neo.SmartContract.Template.UnitTests/templates/neocontractnep17/TestingArtifacts/Nep17ContractTemplate.artifacts.cs # tests/Neo.SmartContract.Template.UnitTests/templates/neocontractowner/TestingArtifacts/OwnableTemplate.artifacts.cs
|
@shargon fixed. the reason of that is because the only difference between old artifact and new artifact is now many space are there, while the comparison actually will ignore space.... thus it will not be updated. |
shargon
reviewed
Oct 26, 2024
tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract2.cs
Outdated
Show resolved
Hide resolved
shargon
reviewed
Oct 27, 2024
shargon
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds the gas price to the artifact, such that we can easily check the optimization detail in git diff.