[SysCall] add support to enum methods, #1169
Open
+1,185
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jim8y
commented
Sep 16, 2024
src/Neo.Compiler.CSharp/MethodConvert/System/SystemCall.Register.cs
Outdated
Show resolved
Hide resolved
Jim8y
commented
Sep 16, 2024
src/Neo.Compiler.CSharp/MethodConvert/System/SystemCall.Register.cs
Outdated
Show resolved
Hide resolved
Jim8y
commented
Sep 16, 2024
src/Neo.Compiler.CSharp/MethodConvert/System/SystemCall.Register.cs
Outdated
Show resolved
Hide resolved
Jim8y
commented
Sep 16, 2024
| @@ -263,6 +272,8 @@ private bool TryProcessSystemMethods(SemanticModel model, IMethodSymbol symbol, | |||
| var key = symbol.ToString()!.Replace("out ", ""); | |||
| key = (from parameter in symbol.Parameters let parameterType = parameter.Type.ToString() where !parameter.Type.IsValueType && parameterType!.EndsWith('?') select parameterType).Aggregate(key, (current, parameterType) => current.Replace(parameterType, parameterType[..^1])); | |||
| if (key == "string.ToString()") key = "object.ToString()"; | |||
| if (key.Contains("System.Enum.GetName<")) key = "System.Enum.GetName<>()"; | |||
There was a problem hiding this comment.
Can not directly process this, cause the name of the method is not the same as its signature that we invokes, so i have to add direct string key.
shargon
reviewed
Sep 17, 2024
shargon
reviewed
Sep 17, 2024
shargon
reviewed
Sep 17, 2024
src/Neo.Compiler.CSharp/MethodConvert/System/SystemCall.Register.cs
Outdated
Show resolved
Hide resolved
shargon
reviewed
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a group of enum methods.