-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature as a standalone .nef file optimizer #1162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to optimize-nef # Conflicts: # src/Neo.Compiler.CSharp/CompilationEngine/CompilationContext.cs
Hecate2
force-pushed
the
optimize-nef
branch
from
September 9, 2024 03:06
eb790eb
to
326db42
Compare
Maybe nef and manifest need cloning before optimization as well |
shargon
reviewed
Sep 9, 2024
src/Neo.Compiler.CSharp/CompilationEngine/CompilationContext.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Shargon <[email protected]>
shargon
reviewed
Sep 9, 2024
Hecate2
commented
Sep 9, 2024
src/Neo.Compiler.CSharp/CompilationEngine/CompilationContext.cs
Outdated
Show resolved
Hide resolved
shargon
reviewed
Sep 9, 2024
Jim8y
approved these changes
Sep 10, 2024
shargon
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any contract .nef file written in any language to be optimized.
Will conflict against #1159 . Kept as draft for now.
Test:
(There may be no additional print for --security-analysis if there is no vulnerability)