optimize HandleMathClamp #1160
Merged
optimize HandleMathClamp #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OpCode.THROW also exists in many other files, mainly for checking value overflows. |
|
you can disable the gasassert for this pr |
Hecate2
commented
Sep 6, 2024
| methodConvert.AddInstruction(OpCode.DROP); | ||
| methodConvert.Jump(OpCode.JMP, endTarget); | ||
| endTarget.Instruction = methodConvert.AddInstruction(OpCode.NOP); | ||
| methodConvert.AddInstruction(OpCode.REVERSE3); // 10 0 5 |
There was a problem hiding this comment.
//We may not use MAX and MIN after REVERSE3 because it's more expensive. MAX&MIN costs 1<<3 each. See the commented codes for a cheaper but larger solution.
…to optimize-clamp # Conflicts: # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Integer.cs # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Math.cs
shargon
reviewed
Sep 9, 2024
Jim8y
approved these changes
Sep 10, 2024
shargon
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not only a performance optimization. max == min should be allowed. This is the same as the behavior of C# https://github.com/dotnet/runtime/blob/5535e31a712343a63f5d7d796cd874e563e5ac14/src/libraries/System.Private.CoreLib/src/System/Math.cs#L636C13-L650C26