update system methods. #1155
update system methods. #1155
Conversation
| @@ -59,6 +59,12 @@ static Instruction() | |||
| } | |||
| } | |||
|
|
|||
| internal Instruction AddTarget(JumpTarget target) | |||
| { | |||
| target.Instruction = this; | |||
There was a problem hiding this comment.
This doesn't add the NOP, isn't it?
There was a problem hiding this comment.
This one will not, we can set jump target to existing opcode, if there is none, we can call InstructionsBuilder.Addtarget and add a nop and attach the jumptarget to it.. This one inside the Instruction is for adding jump target to existing opcode, while the one with the same name AddTarget in the InstructionsBuilder is for situations where we have to set jumptarget to Nop.
I made this change to make it easier to write the code, and make instructoins look shorter.....
I know,,, i made this super huge pr,,,,,, it just keep growing while i was trying to make it work....... have being working on this for 15 hours without resting...... |
|
I tried my best to make it easier for reviewing, and avoided changes to the compile result..... BUT, there is still a case that will change the artifact,,, which is I added |
No description provided.