Skip to content

Commit

Permalink
📝 🎨 Improve description of method equals()
Browse files Browse the repository at this point in the history
(related to #21 )
  • Loading branch information
nelson6e65 committed Jan 2, 2019
1 parent 17e079a commit 099f4d8
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/IEquatable.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ interface IEquatable
{

/**
* Indica si el objeto especificado es igual a la instancia actual.
* Indicates whether the specified object is equal to the current instance.
*
* @param mixed $other Another object to compare equality.
*
Expand Down
2 changes: 1 addition & 1 deletion src/IntString.php
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public function toString()
}

/**
* Indica si el objeto especificado es igual a la instancia actual.
* Indicates whether the specified object is equal to the current instance.
*
* @param IntString|mixed $other
*
Expand Down
6 changes: 2 additions & 4 deletions src/StrictObject.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,11 @@ public function toString()
}

/**
* Indica si el objeto especificado es igual a la instancia actual.
*
* Note: This methods must to be overriden.
* Indicates whether the specified object is equal to the current instance.
*
* @param mixed $other Another object to compare equality.
*
* @return bool
* @return bool Retuns default behaviour of `==`. ***This method must be overridden***.
* */
public function equals($other)
{
Expand Down
4 changes: 3 additions & 1 deletion src/Type.php
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,11 @@ public function toString()


/**
* Indicates whether the specified object is equal to the current instance.
*
* @param Type|mixed $other
*
* @return bool
* @return bool Returns always `false` if `$other` is not a `Type`.
*/
public function equals($other)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Version.php
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public function isValid()
}

/**
* Determina si el objeto $other especificado es igual a la instancia actual.
* Indicates whether the specified object is equal to the current instance.
*
* @param Version $other El otro objeto a comparar.
*
Expand Down

0 comments on commit 099f4d8

Please sign in to comment.