Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nh pathlib refactor #6

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Nh pathlib refactor #6

wants to merge 22 commits into from

Conversation

hulkoba
Copy link

@hulkoba hulkoba commented May 23, 2024 •
edited
Loading

Checklist

  • Added a news entry

@coveralls
Copy link

coveralls commented May 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9448678361

Details

  • 155 of 174 (89.08%) changed or added relevant lines in 11 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 67.762%
Changes Missing Coverage Covered Lines Changed/Added Lines %
conda_smithy/ci_register.py 4 5 80.0%
conda_smithy/github.py 1 2 50.0%
conda_smithy/utils.py 1 2 50.0%
conda_smithy/cli.py 13 17 76.47%
conda_smithy/configure_feedstock.py 78 82 95.12%
conda_smithy/feedstocks.py 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
conda_smithy/lint_recipe.py 1 94.24%
conda_smithy/configure_feedstock.py 5 82.83%
Totals Coverage Status
Change from base Build 9396760438: -0.07%
Covered Lines: 2787
Relevant Lines: 4033
💛 - Coveralls

@hulkoba hulkoba force-pushed the nh-pathlib-refactor branch 2 times, most recently from 06de91f to 2334a45 Compare May 23, 2024 12:22
@AlbaHerrerias AlbaHerrerias force-pushed the nh-pathlib-refactor branch 2 times, most recently from 67ee85b to ab486c3 Compare May 24, 2024 10:34
@hulkoba hulkoba force-pushed the nh-pathlib-refactor branch 12 times, most recently from 9de9192 to 3e1a8c8 Compare May 30, 2024 08:08
@hulkoba hulkoba marked this pull request as ready for review May 30, 2024 08:32
jcoglan
jcoglan reviewed Jun 6, 2024
View reviewed changes
conda_smithy/ci_skeleton.py Outdated Show resolved Hide resolved
jcoglan
jcoglan reviewed Jun 6, 2024
View reviewed changes
conda_smithy/cli.py Outdated Show resolved Hide resolved
@AlbaHerrerias AlbaHerrerias force-pushed the nh-pathlib-refactor branch 2 times, most recently from bf1c445 to 4a60531 Compare June 7, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoglan jcoglan jcoglan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hulkoba @coveralls @jcoglan @AlbaHerrerias