Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project info text and URL made configurable #319

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Project info text and URL made configurable #319

merged 6 commits into from
Sep 22, 2023

Conversation

shreyasshivakumara
Copy link
Contributor

@shreyasshivakumara shreyasshivakumara commented Sep 21, 2023 •
edited
Loading

This pull request enables project text and URL configurable on the sda-auth frontend page.

@shreyasshivakumara shreyasshivakumara self-assigned this Sep 21, 2023
pontus
pontus previously approved these changes Sep 21, 2023
View reviewed changes
@pontus
Copy link
Contributor

pontus commented Sep 21, 2023

Looks fine to me.

@shreyasshivakumara shreyasshivakumara marked this pull request as ready for review September 21, 2023 11:45
pontus
pontus previously approved these changes Sep 21, 2023
View reviewed changes
jbygdell

This comment was marked as outdated.

Sign in to view

@shreyasshivakumara shreyasshivakumara merged commit e414cba into main Sep 22, 2023
28 checks passed
@shreyasshivakumara shreyasshivakumara deleted the fix/sda-auth-config branch September 22, 2023 06:58
@aaperis
Copy link
Contributor

aaperis commented Oct 23, 2023

@shreyasshivakumara @pontus @jbygdell, this doesnot seem to work for me at least locally. (This has not been yet deployed on any cluster as far as I see)

@jbygdell
Copy link
Collaborator

@shreyasshivakumara @pontus @jbygdell, this doesnot seem to work for me at least locally. (This has not been yet deployed on any cluster as far as I see)

Because the container image created from this PR has the tag: v0.0.96 and that is not deployed yet anywhere.

@aaperis
Copy link
Contributor

aaperis commented Oct 23, 2023

Because the container image created from this PR has the tag: v0.0.96 and that is not deployed yet anywhere.

Yes, which I guess we should refrain from until we're sure this works as expected.

@pontus
Copy link
Contributor

pontus commented Oct 23, 2023

Thanks, I'll try to check it out. @aaperis can you give me a hint so I'll know what to look for?

@aaperis
Copy link
Contributor

aaperis commented Oct 23, 2023

See #368 for a fix :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbygdell jbygdell jbygdell approved these changes

@pontus pontus pontus approved these changes

Assignees

@shreyasshivakumara shreyasshivakumara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreyasshivakumara @pontus @aaperis @jbygdell