Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] [charts] #291

Merged
merged 5 commits into from
Sep 13, 2023
Merged

[hotfix] [charts] #291

merged 5 commits into from
Sep 13, 2023

Conversation

jbygdell
Copy link
Collaborator

@jbygdell jbygdell commented Sep 12, 2023 •
edited
Loading

  • Fixes ENV names for the MQ server
  • Adds TLS to the chart deployment tests
  • Fixes TLS settings in sda-svc

@jbygdell jbygdell self-assigned this Sep 12, 2023
@jbygdell jbygdell force-pushed the chart_hotfix branch 5 times, most recently from 2082934 to 90b362f Compare September 12, 2023 18:54
@jbygdell jbygdell changed the title [hotfix] [charts] [sda-mq] [hotfix] [charts] Sep 12, 2023
dbampalikis
dbampalikis approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@dbampalikis dbampalikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will test it later today

@nanjiangshu nanjiangshu merged commit 972ab68 into main Sep 13, 2023
29 checks passed
@nanjiangshu nanjiangshu deleted the chart_hotfix branch September 13, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaperis aaperis aaperis approved these changes

@dbampalikis dbampalikis dbampalikis approved these changes

@nanjiangshu nanjiangshu nanjiangshu approved these changes

@pahatz pahatz Awaiting requested review from pahatz

Assignees

@jbygdell jbygdell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbygdell @nanjiangshu @dbampalikis @aaperis