Docs/add helm chart install instructions #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalinAhlberg
previously approved these changes
Aug 5, 2024
Co-authored-by: Malin Klang <[email protected]>
MalinAhlberg
approved these changes
Aug 7, 2024
nanjiangshu
reviewed
Aug 8, 2024
| @@ -0,0 +1,86 @@ | |||
| # Sensitive Data Archive Helm Charts | |||
There was a problem hiding this comment.
The abbreviation SDA and the full name Sensitive Data Archive are used interchangeably throughout the text. I think we can add the abbreviation (SDA) at the beginning of the text and then use the short name SDA afterwards unless we need to use the full name by purpose.
nanjiangshu
reviewed
Aug 8, 2024
nanjiangshu
reviewed
Aug 8, 2024
nanjiangshu
reviewed
Aug 8, 2024
nanjiangshu
reviewed
Aug 8, 2024
|
@nanjiangshu good suggestions, I opened this PR PR to add them to the source text. |
nanjiangshu
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes https://github.com/NBISweden/LocalEGA-SE-Deployment/issues/737.
Description
The task here is to integrate the newly added chart README from the sensitive-data-archive to the docs aggregator of the NeiC-SDA repo and add the page to the relevant section of the guide Handbook.
There is no need to review closely the text in
docs/guides/charts-overview.mdsince this will be updated when the PR is merged and the weekly cronjob for updating the docs is triggered.