Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared error handler #21

Merged
merged 7 commits into from
Dec 2, 2023
Merged

Add shared error handler #21

merged 7 commits into from
Dec 2, 2023

Conversation

neg4n
Copy link
Owner

@neg4n neg4n commented Oct 29, 2023

No description provided.

@neg4n neg4n added documentation Improvements or additions to documentation enhancement New feature or request tests Related to tests labels Oct 29, 2023
@neg4n neg4n self-assigned this Oct 29, 2023
@neg4n neg4n requested a review from mgrabka October 29, 2023 01:54
@github-actions
Copy link

github-actions bot commented Oct 29, 2023

Coverage report for ./packages/next-api-compose/

St.
Category Percentage Covered / Total
🟢 Statements 100% 291/291
🟢 Branches 100% 35/35
🟢 Functions 100% 4/4
🟢 Lines 100% 291/291

Test suite run success

18 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from 8d9d072

@neg4n
Copy link
Owner Author

neg4n commented Oct 29, 2023

Needs coverage improvement, also, the error handler does not seem to cover the final route handler after the middleware

@neg4n neg4n marked this pull request as draft October 29, 2023 06:14
@neg4n neg4n marked this pull request as ready for review December 2, 2023 13:13
Copy link
Contributor

@mgrabka mgrabka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@neg4n neg4n merged commit 95c81d6 into development Dec 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants