Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass user groups to jupyterhub context #157

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

viniciusdc
Copy link
Collaborator

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@viniciusdc
Copy link
Collaborator Author

viniciusdc commented Apr 2, 2024

By including it as part a spawn hook, this should give us the flexibility to use set a fake auth_state in the future, to any features that require this data

@viniciusdc viniciusdc requested a review from aktech April 3, 2024 12:57
@viniciusdc viniciusdc added the enhancement New feature or request label Apr 3, 2024
@aktech
Copy link
Member

aktech commented Apr 9, 2024

@viniciusdc Thanks for this, can you add a couple of lines of docs to mention that shared environments should be accessible to the user?

@viniciusdc
Copy link
Collaborator Author

viniciusdc commented Apr 9, 2024

Sure thing, we are planning to merge this doc with nebari, so all tutorials would be applicable for this. But I will open something under the env section to notify users about this

@viniciusdc
Copy link
Collaborator Author

I included some docs as a first draft

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viniciusdc this looks good to me. Verified it works.

@aktech aktech merged commit 1bdf512 into main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants