Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting for ansible #144

Merged
merged 9 commits into from
Feb 27, 2024
Merged

Add linting for ansible #144

merged 9 commits into from
Feb 27, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Feb 21, 2024

Reference Issues or PRs

Fixes #142

This applied ansible-lint --fix for overall consistency in ansible files. I have skipped a bunch of linting tests in .ansible-lint so that we can fix them over time without introducing more linting problems.

Also skips the vagrant tests, until we fix it as it was never working anyways and gives a false view of failure.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@aktech aktech requested a review from viniciusdc February 21, 2024 20:43
@aktech
Copy link
Member Author

aktech commented Feb 27, 2024

@viniciusdc are you happy for me to merge this?

@viniciusdc
Copy link
Collaborator

Hi @aktech i was hoping to have a chance to test deploying those changes to double check if the variable renaming would interfere in anything

@viniciusdc
Copy link
Collaborator

But I am okay with merging and testing later, I can open another PR with fixes if needed

@aktech
Copy link
Member Author

aktech commented Feb 27, 2024

I just deployed it and it worked after a couple of issues, which I have fixed and pushed now to the PR.

Copy link
Collaborator

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for checking the deployment @aktech

@aktech
Copy link
Member Author

aktech commented Feb 27, 2024

Thanks for the review @viniciusdc 🎉

@aktech aktech merged commit acab774 into main Feb 27, 2024
3 checks passed
@aktech aktech deleted the lint branch February 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ansible lint in the CI for consistency across yaml files
2 participants