-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting for ansible #144
Conversation
@viniciusdc are you happy for me to merge this? |
Hi @aktech i was hoping to have a chance to test deploying those changes to double check if the variable renaming would interfere in anything |
But I am okay with merging and testing later, I can open another PR with fixes if needed |
I just deployed it and it worked after a couple of issues, which I have fixed and pushed now to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for checking the deployment @aktech
Thanks for the review @viniciusdc 🎉 |
Reference Issues or PRs
Fixes #142
This applied
ansible-lint --fix
for overall consistency in ansible files. I have skipped a bunch of linting tests in.ansible-lint
so that we can fix them over time without introducing more linting problems.Also skips the vagrant tests, until we fix it as it was never working anyways and gives a false view of failure.
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?