Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JupyterLab under My Apps as Default App #63

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Move JupyterLab under My Apps as Default App #63

merged 3 commits into from
Jan 10, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Jan 9, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

N/A

Screenshots

Screenshot 2024-01-09 at 4 54 15 PM Screenshot 2024-01-09 at 4 54 23 PM

Any other comments?

  • Updated to display Default App under My Apps as JupyerLab
  • Updated to disable Edit and Delete actions for Default App
  • Add/Update Unit Tests
  • This PR does not remove JupyterLab from Services

@dharhas
Copy link
Member

dharhas commented Jan 9, 2024

@jbouder can the "delete" button be disabled for this? If not lets make an issue to look at this again for the next release.

edit: nvm I see you already did that.

@jbouder jbouder changed the title Move JupyterLab under under My Apps as Default App Move JupyterLab under My Apps as Default App Jan 9, 2024
@aktech
Copy link
Member

aktech commented Jan 10, 2024

Added backend changes, should be good to go now.

@aktech aktech merged commit 464532b into nebari-dev:main Jan 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants