Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab Not Started App Card Fix #554

Closed
wants to merge 4 commits into from
Closed

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Dec 11, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:18pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:18pm

@jbouder
Copy link
Collaborator Author

jbouder commented Dec 11, 2024

Closing...had some incorrect assumption on these changes.

@jbouder jbouder closed this Dec 11, 2024
@viniciusdc
Copy link
Contributor

@jbouder Testing this locally with the following config extras:

c.KubeSpawner.profile_list = [
    {
        "description": "Stable environment with 0.5-1 cpu / 0.5-1 GB ram",
        "display_name": "Small Instance",
        "slug": "small-instance",
    },
    {
        "description": "Stable environment with 0.5-1 cpu / 0.5-1 GB ram",
        "display_name": "Small Instance 2",
        "slug": "small-instance-2",
    },
]

This led to a similar issue, though this time I got redirected to a 404 page (blank):
Peek 11-12-2024 11-29

Is there something else that I might have missed?

@jbouder
Copy link
Collaborator Author

jbouder commented Dec 11, 2024

@viniciusdc , you can disregard this PR. I thought something else was going on. Ended up being much more simple. Try this PR: #555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants