deploy app from git

[kildre]

Reference Issues or PRs

What does this implement/fix?

Adds functinality to the Deploy App form to pull in an app from a git repo
Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• [x ] New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• [x ] Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• [ x] Did you test the pull request locally?
• [ x] Did you add new tests?

Documentation

Access-centered content checklist

Text styling

• [x ] The content is written with plain language (where relevant).
• [ x] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
• [ x] All links describe where they link to (for example, check the Nebari website).
• [ x] This content adheres to the Nebari style guides.

Non-text content

• [ x] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
• If there are emojis, there are not more than three in a row.
• Don't use flashing GIFs or videos.
• If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jhub-apps	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 6:39pm
jhub-apps-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 6:39pm

[jbouder]

A couple of nitpicks before I get into a code review:

1. I would think the radio buttons would make more sense being below the Page Title, from both a visual and accessibility point of view
2. I can't think of a reason why these options would be visible when in headless mode, I would suggest hiding those when headless as well

[jbouder]

Let me know if there are any questions

[jbouder]

Should just be a little more cleanup.

[kildre]

@jbouder made the changes to the Radio buttons, put them below the Deploy titles.

[kildre]

@aktech made updates to repository config object

[aktech]

Thanks, it needs to be passed in the server endpoint as well, it isn't at the moment: /server

    "user_options": {
        // ...
        "repository": {"url": "https://github.com/nebari-dev/jhub-apps-from-git-repo-example.git"}
    }

[kildre]

@aktech Ooops!
Made the update to user_options

[aktech]

The "keep app alive" and "public" are false in the UI toggle, even thogh the API response has true for both of them:

[kildre]

Made corrections to keep-alive and public

[aktech]

We should display the error message from backend:

As in this case repository is valid, but there was some other error:

[kildre]

@aktech made the Error title more generic, to 'ERROR'
please review PR again.

[aktech]

Looks good to me. Thanks for working on this. 🎉

[aktech]

Looks like all the tests are failing after merge to main, can you take a look: https://github.com/nebari-dev/jhub-apps/actions/runs/11889273170/job/33132014404 @kildre @jbouder

[aktech]

Never mind, the test failures are unrelated. Looks like the new PyJWT version released yesterday, introduced some breaking changes. I have created a PR to pin it for now: #532