Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Redirection or Navigation Post App Deployment in JupyterLab iframe #509

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Nov 1, 2024

Reference Issues or PRs

Fixes #508

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Screenshots

Screenshot 2024-11-01 at 11 20 16 AM

Any other comments?

  • Added new success page with link to open app in new tab
  • Updated applicable pages to direct to this page when headless

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 5:28pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 5:28pm

Copy link
Contributor

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nenb
Copy link
Contributor

nenb commented Nov 1, 2024

@jbouder This looks great! The only thing I noticed locally is that when I click on the Deploy App button, it redirects to the bottom of the success page - I then have to scroll up to see the message (see the attached GIF). As it's largely a blank screen, this can be a little confusing for users.

Is it possible/in scope to redirect to the top of the success page?

output

@nenb
Copy link
Contributor

nenb commented Nov 1, 2024

Confirmed that this is now working locally. Thanks @jbouder!

@jbouder jbouder merged commit 6128710 into nebari-dev:main Nov 1, 2024
25 checks passed
@jbouder jbouder deleted the headless-success branch November 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Handle Redirection or Navigation Post App Deployment in JupyterLab iframe
3 participants