-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy from git #505
Deploy from git #505
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
setShouldValidate(true); | ||
|
||
const gitHubUrlPattern = | ||
/^(https?:\/\/)?(www\.)?github\.com\/[\w-]+\/[\w-]+$/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git repo url is the clone url, this could be any valid git clone url (also not necessarily from github), for example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the pattern to be more inclusive:
const gitRepoUrlPattern =
/^(https?://)?[\w.-]+/[\w-]+/[\w-]+(.git)?$/i;
…lly be required field
…lly be required field
…into deploy-from-git
Had an issue with index.js. Reverted a merge but couldn't align my index.js so killing this pr and opened another one. |
Reference Issues or PRs
What does this implement/fix?
Add functinality to the Deploy App form to pull in an app from a git repo
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?