Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy from git #505

Closed
wants to merge 27 commits into from
Closed

Deploy from git #505

wants to merge 27 commits into from

Conversation

kildre
Copy link
Contributor

@kildre kildre commented Oct 21, 2024

Reference Issues or PRs

What does this implement/fix?

Add functinality to the Deploy App form to pull in an app from a git repo
Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:48pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 1:48pm

setShouldValidate(true);

const gitHubUrlPattern =
/^(https?:\/\/)?(www\.)?github\.com\/[\w-]+\/[\w-]+$/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git repo url is the clone url, this could be any valid git clone url (also not necessarily from github), for example:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the pattern to be more inclusive:
const gitRepoUrlPattern =
/^(https?://)?[\w.-]+/[\w-]+/[\w-]+(.git)?$/i;

@kildre
Copy link
Contributor Author

kildre commented Nov 1, 2024

Had an issue with index.js. Reverted a merge but couldn't align my index.js so killing this pr and opened another one.

@kildre kildre deleted the deploy-from-git branch November 1, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants