Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for Public Sharing #38

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Update UI for Public Sharing #38

merged 3 commits into from
Jan 5, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Jan 5, 2024

Reference Issues or PRs

#13

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

N/A

Screenshots

Screenshot 2024-01-05 at 1 30 21 PM Screenshot 2024-01-05 at 1 30 31 PM

Any other comments?

  • Added new toggle component
  • Updated App Form to allow sharing to public
  • Updated App Grid to display Public indicator
  • Add/Update unit tests

@aktech
Copy link
Member

aktech commented Jan 5, 2024

Looks pretty!

@aktech aktech merged commit b6000f5 into nebari-dev:main Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants