Add id to logo for testing. Update selectors.

nebari-dev · Nov 7, 2024 · edc22c0 · edc22c0
1 parent 77009f1
commit edc22c0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/jhub_apps/static/js/index.js b/jhub_apps/static/js/index.js
diff --git a/jhub_apps/tests/tests_e2e/test_integration.py b/jhub_apps/tests/tests_e2e/test_integration.py
@@ -51,9 +51,9 @@ def test_panel_app_creation(playwright: Playwright, with_server_options) -> None
         page.goto(BASE_URL)
         sign_in_and_authorize(page, username=f"admin-{app_suffix}", password="password")
         # Verify that the page is loaded
-        logo = page.get_by_alt_text("logo").last()
+        logo = page.locator("id=app-logo")
         expect(logo).to_be_visible()
-        profile_menu = page.locator("id=profile-menu-btn").last()
+        profile_menu = page.locator("id=profile-menu-btn")
         expect(profile_menu).to_be_visible()
         page_title = page.locator("h1")
         expect(page_title).to_have_text("Home")
@@ -97,16 +97,17 @@ def create_app(
 ):
     logger.info("Creating App")
     # Verify that the page is loaded
-    logo = page.get_by_alt_text("logo").last()
+    logo = page.locator("id=app-logo")
     expect(logo).to_be_visible()
-    profile_menu = page.locator("id=profile-menu-btn").last()
+    profile_menu = page.locator("id=profile-menu-btn")
     expect(profile_menu).to_be_visible()
-    page_title = page.locator("h1")
-    expect(page_title).to_have_text("Deploy a new app")
+
     # Deploy App
     deploy_button = page.get_by_role("button", name="Deploy App")
     expect(deploy_button).to_be_visible()
     deploy_button.click()
+    page_title = page.locator("h1")
+    expect(page_title).to_have_text("Deploy a new app")
     logger.info("Fill App display Name")
     display_name_field = page.get_by_label("*Name")
     expect(display_name_field).to_be_visible()

diff --git a/ui/src/components/navigation/navigation.tsx b/ui/src/components/navigation/navigation.tsx
@@ -371,7 +371,7 @@ export const TopNavigation = ({ ...props }): React.ReactElement => {
             sx={{ flexGrow: 1, display: { xs: 'none', sm: 'block' } }}
           >
             <Link href={APP_BASE_URL}>
-              <img src={getAppLogoUrl()} alt="logo" height="28" />
+              <img id="app-logo" src={getAppLogoUrl()} alt="logo" height="28" />
             </Link>
           </Box>
           <Box sx={{ display: { xs: 'none', sm: 'block' } }}>