Skip to content

Commit

Permalink
add a comment about deterministic url
Browse files Browse the repository at this point in the history
  • Loading branch information
aktech committed Nov 25, 2024
1 parent 129da48 commit 9a77366
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions jhub_apps/hub_client/hub_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ def create_server(self, username: str, servername: str, user_options: UserOption
normalized_servername = self.normalize_server_name(servername)
logger.info("User servers", user_servers=user_servers.keys())
# If server with the given name already exists
# This is to allow users to create apps with a reasonably deterministic url
# instead of a random url everytime. This is more of a temporary solution, until
# we have an explicit way to control the url in the UI itself.
if normalized_servername in user_servers:
unique_servername = f"{normalized_servername}-{uuid.uuid4().hex[:7]}"
else:
Expand Down

0 comments on commit 9a77366

Please sign in to comment.