Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use node: prefix to bypass require.cache call for builtins #236

Merged
merged 1 commit into from
Sep 19, 2023
Merged

test: use node: prefix to bypass require.cache call for builtins #236

merged 1 commit into from
Sep 19, 2023

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Sep 12, 2023

Allows redundant require.cache calls to be bypassed for builtin modules, saving a few yoctoseconds.

See https://nodejs.org/api/modules.html#core-modules and discussion in nodejs/node repo regarding why require.cache calls are redundant for builtins.

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@simoneb simoneb merged commit e9b23fb into nearform:main Sep 19, 2023
4 of 5 checks passed
@Fdawgs Fdawgs deleted the test/builtins branch September 19, 2023 18:41
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants