-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(standards): get rid of confusing tokens folder #420
base: master
Are you sure you want to change the base?
Conversation
Your Render PR Server URL is https://nomicon-pr-420.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cdbs9r82i3mmsu5slulg. |
I re-checked the links, and they look good. I guess the checker takes the links from master |
@telezhnaya Thanks for bringing it up here, and proposing a change that we can review. I feel we need a better structure there. "Tokens" section reflects the common implementation detail, but it does include the native NEAR token here, so it is indeed a bad taxonomy here. Yet, flattening it up to the "Standards" level is also not productive (though, it is not a. blocker) We will also need to figure out how to configure redirects for the old links as there are way too many of them already shared in various documentation articles, StackOverflow answers, etc. I believe this is actually a huge blocker for this PR to land. @ori-near We will need some help here from someone who can help organize the setup, so we can easily configure redirects from the old links to the new place |
Thank you @telezhnaya for submitting this Nomicon change. As a moderator, I am moving it to the REVIEW stage and would like to ask the @near/wg-contract-standards working group members to assign 1 Technical Reviewer to complete a review (see expectations). If you want to assign yourself, please mention that you are acting as the Technical Reviewer. Please find some guidelines below for completing the technical review. Technical Review Guidelines
Please tag the @near/wg-contract-standards working group once you are done, so they can merge or close the PR. Thanks again. |
As a moderator, we are waiting for the Contract Standards Work Group to have more capacity to review this NEP. We will pause it for now. |
Some points why I'm against this grouping:
Coin
for FTs and native balance, andToken
here could be confusing for the users.