- Cleanup and pod fixes 0.1.4

nbhasin2 · Jan 1, 2017 · 4382352 · 4382352
1 parent aab5312
commit 4382352
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 26 deletions.
diff --git a/NBNavigationController.podspec b/NBNavigationController.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = 'NBNavigationController'
-  s.version          = '0.1.3'
+  s.version          = '0.1.4'
   s.summary          = 'Navigation controller with custom transition'
 
   s.description      = <<-DESC

diff --git a/NBNavigationController/BaseTransition.swift b/NBNavigationController/BaseTransition.swift
@@ -9,8 +9,8 @@
 import Foundation
 import UIKit
 
-class BaseTransition: NSObject {
-    var transitionDuration: TimeInterval = 1.0
+public class BaseTransition: NSObject {
+    public var transitionDuration: TimeInterval = 1.0
 
     convenience init(transitionDuration:TimeInterval) {
         self.init()

diff --git a/NBNavigationController/BottomUpTransition.swift b/NBNavigationController/BottomUpTransition.swift
@@ -26,13 +26,13 @@
 import Foundation
 import UIKit
 
-class BottomUpTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
+public class BottomUpTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
 
-    func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
+    public func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
         return transitionDuration
     }
 
-    func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
+    public func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
         let container = transitionContext.containerView
         guard
 

diff --git a/NBNavigationController/FadeInTransition.swift b/NBNavigationController/FadeInTransition.swift
@@ -28,13 +28,13 @@ import Foundation
 import UIKit
 
 
-class FadeInTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
+public class FadeInTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
 
-    func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
+    public func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
         return transitionDuration
     }
 
-    func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
+    public func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
         let container = transitionContext.containerView
         guard
             let toView = transitionContext.view(forKey: UITransitionContextViewKey.to),

diff --git a/NBNavigationController/FadeOutTransition.swift b/NBNavigationController/FadeOutTransition.swift
@@ -26,13 +26,13 @@
 import Foundation
 import UIKit
 
-class FadeOutTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
+public class FadeOutTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
 
-    func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
+    public func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
         return transitionDuration
     }
 
-    func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
+    public func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
         let container = transitionContext.containerView
         guard
             let toView = transitionContext.view(forKey: UITransitionContextViewKey.to),

diff --git a/NBNavigationController/NBNavigationController.swift b/NBNavigationController/NBNavigationController.swift
@@ -25,20 +25,20 @@
 
 import UIKit
 
-class NBNavigationController: NSObject {
+public class NBNavigationController: NSObject {
 
-    var customTransition: UIViewControllerAnimatedTransitioning?
-    fileprivate weak var previousDelegate: UINavigationControllerDelegate?
+    public var customTransition: UIViewControllerAnimatedTransitioning?
+    public weak var delegate: UINavigationControllerDelegate?
 
-    func pushViewController(_ controller: UIViewController, ontoNavigationController navigationController: UINavigationController, animatedTransition: UIViewControllerAnimatedTransitioning) {
-        self.previousDelegate = navigationController.delegate
+    public func pushViewController(_ controller: UIViewController, ontoNavigationController navigationController: UINavigationController, animatedTransition: UIViewControllerAnimatedTransitioning) {
+        self.delegate = navigationController.delegate
         self.customTransition = animatedTransition
         navigationController.delegate = self
         navigationController.pushViewController(controller, animated: true)
     }
 
-    func popNavigationController(_ navigationController: UINavigationController, animatedTransition: UIViewControllerAnimatedTransitioning) {
-        self.previousDelegate = navigationController.delegate
+    public func popNavigationController(_ navigationController: UINavigationController, animatedTransition: UIViewControllerAnimatedTransitioning) {
+        self.delegate = navigationController.delegate
         self.customTransition = animatedTransition
         navigationController.delegate = self
         navigationController.popViewController(animated: true)
@@ -49,13 +49,13 @@ class NBNavigationController: NSObject {
 
 extension NBNavigationController: UINavigationControllerDelegate{
 
-    func navigationController(_ navigationController: UINavigationController, animationControllerFor operation: UINavigationControllerOperation, from fromVC: UIViewController, to toVC: UIViewController) -> UIViewControllerAnimatedTransitioning? {
+    public func navigationController(_ navigationController: UINavigationController, animationControllerFor operation: UINavigationControllerOperation, from fromVC: UIViewController, to toVC: UIViewController) -> UIViewControllerAnimatedTransitioning? {
         return self.customTransition
     }
 
-    func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
-        navigationController.delegate = previousDelegate
-        previousDelegate = nil
+    public func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
+        navigationController.delegate = self.delegate
+        self.delegate = nil
     }
 }
 
diff --git a/NBNavigationController/TopDownTransition.swift b/NBNavigationController/TopDownTransition.swift
@@ -26,13 +26,13 @@
 import Foundation
 import UIKit
 
-class TopDownTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
+public class TopDownTransition: BaseTransition, UIViewControllerAnimatedTransitioning {
 
-    func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
+    public func transitionDuration(using transitionContext: UIViewControllerContextTransitioning?) -> TimeInterval {
         return transitionDuration
     }
 
-    func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
+    public func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
         let container = transitionContext.containerView
         guard
             let toView = transitionContext.view(forKey: UITransitionContextViewKey.to),