Multikey status #104
Open
Multikey status #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the API, cli and web interface to display the status
in case multiple usernames get registered to the same realname.
This introduce an API change int the `client/status` endpoint
which now returns a dict in every cases, otherwise it'll become
difficult for the client handle the data.
Before it the result was:
- no keys: the None string
- one key: a json dict with attributes like {.status } etch
- multiple keys: a json dict with usernames as key and dicts as above
as values
Now:
- no keys: empty dict
- multiple / single key: a json dict in the form
{ "username" : { "status" = "",...}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added the ability to display multiple keys for the same realname in the status page.
This imply a small API change in the
client/statusendpoint. In a previous implementation I've tried to preserve the original APIbut it then become difficult to handle the response. So I've come up with this version.
The ability to associate multiple keys with one realname is already present on mainline, it was missing only the status page which was displaying only the last one.