Add basic support for proxy #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Should I merge? |
seberm
force-pushed
the
feature/add-proxy-support
branch
from
ce2896f
to
c5009ed
Compare
|
Hello @fiatjaf, I think that this is not supported in current lightningd-gjson-rpc version. That's why I created this PR: Please, let me know, what you think, feel free to make any changes. The golang is not my strong suit. |
|
Merged that one and published as v1.6.2. |
seberm
force-pushed
the
feature/add-proxy-support
branch
from
c5009ed
to
3284f99
Compare
fiatjaf
force-pushed
the
master
branch
4 times, most recently
from
519df53
to
feeff0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the proxy configuration from clightning configuration file and use it for all http/https connections.
We need to proxy all http/https trustedcoin connections via Tor in a nix-bitcoin project, see the PR here:
We currently set the
Environment="HTTPS_PROXY=socks5://127.0.0.1:9050"andEnvironment="HTTP_PROXY=socks5://127.0.0.1:9050"env variables in a clightning systemd service configuration as a workaround: