Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting widget expanded #81

Merged
merged 31 commits into from
Oct 1, 2024
Merged

Setting widget expanded #81

merged 31 commits into from
Oct 1, 2024

Conversation

eriktks
Copy link
Member

@eriktks eriktks commented Jul 23, 2024

Issue

Continuing the work of Flavio Hafner on issue #14 in PR #33 in making a widget that determines the setting of a text

Description of changes to setting widget

  • added progress bar
  • code refactoring
  • replaced lemma output by event+location+date output
  • made possible inclusion of additional entities list
  • select most frequent of generated three entities
  • visualize text analysis
  • use additional data from WikiData

Future work (create new issue for this)

Includes

  • Code changes
  • Tests
  • Documentation

@ThijsVroegh ThijsVroegh self-requested a review September 23, 2024 07:24
@eriktks eriktks marked this pull request as ready for review September 24, 2024 16:53
@eriktks eriktks mentioned this pull request Sep 26, 2024
3 tasks
@eriktks eriktks added the enhancement New feature or request label Sep 26, 2024
@eriktks eriktks self-assigned this Sep 30, 2024
Copy link
Collaborator

@ThijsVroegh ThijsVroegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the code and inspected the code changes. The setting widget runs well, and the option to select an entity list also works as it should. The datatable with the selection of main setting aspects per story was also inspected and looks good.

@eriktks eriktks merged commit 4b1826d into master Oct 1, 2024
3 checks passed
@eriktks eriktks deleted the setting-widget-expanded branch October 1, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants