Tupelize corpus #32
Merged
Tupelize corpus #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leave this be for the moment.. Related to the setting widget, s odepending on how we are going to develop the widget further, we can later decide on deleting this PR, or not |
eriktks
requested changes
Sep 30, 2024
There was a problem hiding this comment.
This PR adds a useful function to the code and tests it. It is unfinished: the function is defined but not called. But the code is tested and the test function could be used as a blueprint for the other code.
The code and test work, and the code looks ok.
We do suggest to move the test file and test data to the standard test directory (tests) before merging
| @@ -4,6 +4,8 @@ | |||
| import sre_constants | |||
| from typing import Any, Iterable, List, Set | |||
| import numpy as np | |||
| import pandas as pd | |||
| @@ -290,3 +291,18 @@ def find_verb_ancestor(token): | |||
|
|
|||
| # If no verb ancestor found, return None | |||
| return None | |||
|
|
|||
| def tupelize_corpus(corpus: Corpus): | |||
There was a problem hiding this comment.
tupelize_corpus is defined but not used
|
This PR was included in PR #110 and was closed when that PR was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I separated out the code from
orange-story-navigator/orangecontrib/storynavigation/widgets/OWSNTagger.py
Line 103 in 80d4cf1
to a separate function that can be reused by other widgets (among others, in #14 )
tests run with
@kodymoodley , if you agree, before merging I'll replace the relevant bit in the line cited above with this function, too.
Description of changes
Includes