-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag future tense verbs #127
base: master
Are you sure you want to change the base?
Conversation
# Loop through each token in the sentence | ||
for tok in tags: | ||
lemma_value = tok[10] | ||
text_value = tok[5] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tok[5] contains the story_navigator_tag, not the token text. Use in tok[2] instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the code and examined the changes. In the changes tok[5] should be replaced by tok[2] to get the text_value. Otherwise the code changes look fine. The tests were mostly fine. There was one exception: in "zullen en willen vergeten" where "willen" was tagged as future verb. This could have been avoided by checking the dependency relations but this is something which can be done later. Thanks for this work!
This pull request introduces the ability to tag future tense verbs in the action analysis module. It includes updates to both the backend logic for tagging verbs and the user interface to support this new feature. This solves issue #93
Backend changes:
__postag_sents
andpostag_text
methods by introducing a newfuture_vbz
parameter.future_verb
column to thecomplete_data_columns
list in theTagger
class.__process_dutch_future_verbs
method to identify future tense verbs in Dutch.__parse_tagged_story
method to include future tense verbs in the story dataframe.UI changes:
OWSNActionAnalysis
widget.show_docs
method to pass thefuture_vbz
parameter.