-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: User Brew Theme Write-in #3923
base: master
Are you sure you want to change the base?
Conversation
Needs: - [ ] opinions on UI placement - [ ] opinions on best choice for displaying a write-in based User Brew ( flip to writin box? Add to drop-down list? )
Regarding opinions on the actual questions about what this should look like: What about a dropdown menu option at the bottom that says "User Theme...". Choosing that displays the text input for writing in your own, below the theme select. If something is already entered in the user theme input, and then they select an included theme, it should hide the user theme input again. But in state, it shouldn't clear that user input quite yet, in case the user decides to go back to using the write-in option again-- they shouldn't have to enter it again. But preserving this value is just a client-side thing...reloading the page wouldn't preserve it. Does that make sense? |
Yeah, that arrow was duplicated from the thumbnail hider and isn't the most obvious with the length of the fake pulldown. Holding in state makes sense. |
Still issues with saving the state of the theme pulldowns and collecting the written in theme.
Description
A first pass at adding a write-in option for User Brews. Functional, but fugly. Provided for feedback.
Needs:
Related Issues or Discussions
QA Instructions, Screenshots, Recordings
Reviewer Checklist
Please replace the list below with specific features you want reviewers to look at.
*Reviewers, refer to this list when testing features, or suggest new items *