-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Homebrewery as an Electron App #3502
base: master
Are you sure you want to change the base?
Conversation
#1537 was raised, we would need to get rid of those anyway.
If we are really working on a local version, we might as well use a different login system, similar to a OS login, simply username and password, and define a folder to save brews for every user.
Right, we need to change how links work in local, or change it to a windowless browser instance, with multiple tabs.. |
Or just specify a new value for EDIT: A quick test of this shows that the |
This makes me think of https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/showModal |
Why would there be an account system at all? |
For the same reason windows offers different accounts, multiple people might want multiple accounts in the same computer, i say we keep them for the local version. |
If we were able to link to file system and thus have a users in their own folders, there might be less need for an account system. That said, I still expect that some users will want to lock their documents so that it can't be viewed accidentally - and thus if they are exposed in the filesystem, they will not be protected. |
This draft PR is some initial work towards enabling the use of Homebrewery locally as a standalone Electron app.
While this PR produces the base functionality, the following issues have been identified:
prompt
,alert
,confirm
all do not work in ElectronJSprompt
If you experiment with this and strike any issues, please record them here.