Restrict valid priority group names #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: R.I.Pienaar <[email protected]>
derekcollison
pushed a commit
to nats-io/nats-server
that referenced
this pull request
Nov 12, 2024
After round of feedback, few changes were requested: **Fix unpin advisory name** Copy-paste mistake was made in unpin advisory name. **Fix PinnedTS** It was meant to return time when pinned happened, not the daedline. **Add check for group name** As the ADR for Priority Groups was [also updated](nats-io/nats-architecture-and-design#311) after feedbach, this PR implements that. cc @ripienaar @jnmoyne Signed-off-by: Tomasz Pietrek <[email protected]> --------- Signed-off-by: Tomasz Pietrek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.