Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 235 remove dask dependency #236

Merged
merged 7 commits into from
Sep 6, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Sep 6, 2024

GitHub Issue: #235

Description

Removed the unused dependency on dask.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://stitchee--236.org.readthedocs.build/en/236/

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.95%. Comparing base (affd559) to head (2bced18).

Files with missing lines Patch % Lines
concatenator/dimension_cleanup.py 9.09% 10 Missing ⚠️
concatenator/dataset_and_group_handling.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
- Coverage    86.18%   85.95%   -0.23%     
===========================================
  Files           11       11              
  Lines          637      641       +4     
===========================================
+ Hits           549      551       +2     
- Misses          88       90       +2     
Flag Coverage Δ
integration 44.92% <23.52%> (+0.03%) ⬆️
unittests 83.46% <23.52%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth marked this pull request as ready for review September 6, 2024 15:19
@danielfromearth danielfromearth merged commit 44c299f into develop Sep 6, 2024
5 checks passed
@danielfromearth danielfromearth deleted the feature/issue-235-remove-dask-dependency branch September 6, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants