Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.3.0 #224

Merged
merged 168 commits into from
Jul 15, 2024
Merged

Release/1.3.0 #224

merged 168 commits into from
Jul 15, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Jul 10, 2024

[1.3.0]

Changed

Added

Fixed

danielfromearth and others added 30 commits April 9, 2024 13:39
issue-133 again - add missing index.md and styles.css
…-stitchee-function

Feature/issue 185 refactor args for stitchee function
@danielfromearth danielfromearth marked this pull request as draft July 10, 2024 14:27
@danielfromearth
Copy link
Collaborator Author

danielfromearth commented Jul 10, 2024

@ank1m, I think this is just about ready. Can you look it over quickly too when you get a chance?
I marked this PR temporarily as "draft" only because I'd like to update the changelog format (to use "Common Changelog" like we just finished converting over to for earthaccess) before we merge it — but I'm not making any additional functional changes tot his PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 85.32110% with 16 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (b27270c) to head (1399d98).

Files Patch % Lines
concatenator/file_ops.py 73.46% 13 Missing ⚠️
concatenator/attribute_handling.py 77.77% 2 Missing ⚠️
concatenator/harmony/download_worker.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #224       +/-   ##
===========================================
+ Coverage   10.74%   85.01%   +74.26%     
===========================================
  Files          11       11               
  Lines         642      634        -8     
===========================================
+ Hits           69      539      +470     
+ Misses        573       95      -478     
Flag Coverage Δ
integration 44.95% <54.12%> (?)
unittests 82.49% <84.40%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth marked this pull request as ready for review July 11, 2024 21:33
@danielfromearth
Copy link
Collaborator Author

All ready from my end! Let me know when you think so too, @ank1m!

Copy link
Collaborator

@ank1m ank1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@danielfromearth danielfromearth merged commit 2c845e1 into main Jul 15, 2024
2 checks passed
@danielfromearth danielfromearth deleted the release/1.3.0 branch July 15, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants