Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified battery model from tutorial #176

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Nov 12, 2024

Added model that was built in the tutorial to the models subpackage. Added to test and documentation.

Also tested by updating PHM tutorial to use this model. Confirmed behavior is the same.

Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link

@chetankul chetankul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It was nice to see it converging to parameters with a few steps.

@teubert teubert merged commit 85e2e39 into dev Nov 13, 2024
29 checks passed
@teubert teubert deleted the 37-simplified-equivalent-circuit-battery-model branch November 13, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants