-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the disabled attribute on a valid element - the button. #7914
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7914 +/- ##
===========================================
+ Coverage 57.67% 81.01% +23.33%
===========================================
Files 677 435 -242
Lines 27373 13593 -13780
Branches 2689 0 -2689
===========================================
- Hits 15787 11012 -4775
+ Misses 11247 2581 -8666
+ Partials 339 0 -339
see 251 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tiny nitpick, but in my opinion, explicitly having an expect on await page.getByLabel('Add Criteria - Enabled')
would be nice. Having
await page.getByLabel('Add Criteria - Enabled').click();
does the same effect though so I'm good.
Can you add testing instructions, @shefalijoshi ? |
e2e/tests/functional/plugins/conditionSet/conditionSetOperations.e2e.spec.js
Show resolved
Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSetOperations.e2e.spec.js
Outdated
Show resolved
Hide resolved
Done. |
Closes VIPERGC-670
Describe your changes:
Move the disabled attribute from the (invalid)
div
element to thebutton
element.Note that this CSS was likely causing the
div
to be perpetually disabled.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist