Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the disabled attribute on a valid element - the button. #7914

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Oct 24, 2024

Closes VIPERGC-670

Describe your changes:

Move the disabled attribute from the (invalid) div element to the button element.
Note that this CSS was likely causing the div to be perpetually disabled.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added this to the Build 9 RC11 milestone Oct 24, 2024
@shefalijoshi shefalijoshi changed the title Use the disabled attribute on a valid tag - the button. Use the disabled attribute on a valid element - the button. Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.01%. Comparing base (2010f2e) to head (fd8422e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7914       +/-   ##
===========================================
+ Coverage   57.67%   81.01%   +23.33%     
===========================================
  Files         677      435      -242     
  Lines       27373    13593    -13780     
  Branches     2689        0     -2689     
===========================================
- Hits        15787    11012     -4775     
+ Misses      11247     2581     -8666     
+ Partials      339        0      -339     
Flag Coverage Δ
e2e-ci 62.48% <ø> (+0.51%) ⬆️
e2e-full 74.19% <ø> (+16.06%) ⬆️
unit ?

see 251 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2010f2e...fd8422e. Read the comment docs.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tiny nitpick, but in my opinion, explicitly having an expect on await page.getByLabel('Add Criteria - Enabled') would be nice. Having
await page.getByLabel('Add Criteria - Enabled').click(); does the same effect though so I'm good.

@davetsay
Copy link
Contributor

davetsay commented Nov 5, 2024

Can you add testing instructions, @shefalijoshi ?

@shefalijoshi
Copy link
Contributor Author

Can you add testing instructions, @shefalijoshi ?

Done.

@unlikelyzero unlikelyzero enabled auto-merge (squash) November 5, 2024 19:55
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 5, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Nov 5, 2024
@unlikelyzero unlikelyzero merged commit ea9947c into master Nov 5, 2024
27 of 29 checks passed
@unlikelyzero unlikelyzero deleted the fix-condition-disabled branch November 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants