Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(visual): Stabilize compass per timestamp #7866

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Oct 3, 2024

Partially addresses #7549

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.47%. Comparing base (4415fe7) to head (be8f413).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7866      +/-   ##
==========================================
+ Coverage   57.62%   62.47%   +4.84%     
==========================================
  Files         675      434     -241     
  Lines       27318    13585   -13733     
  Branches     2673        0    -2673     
==========================================
- Hits        15742     8487    -7255     
+ Misses      11240     5098    -6142     
+ Partials      336        0     -336     
Flag Coverage Δ
e2e-ci 62.38% <100.00%> (+0.07%) ⬆️
e2e-full 23.48% <0.00%> (-30.50%) ⬇️
unit ?
Files with missing lines Coverage Δ
example/imagery/plugin.js 84.74% <100.00%> (ø)
src/utils/random.js 100.00% <100.00%> (ø)

... and 374 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4415fe7...be8f413. Read the comment docs.

@akhenry akhenry added this to the Build 9 RC11 milestone Oct 8, 2024
@ozyx ozyx marked this pull request as ready for review October 9, 2024 21:41
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Oct 10, 2024
@ozyx ozyx merged commit f4cf9c7 into master Oct 10, 2024
50 of 61 checks passed
@ozyx ozyx deleted the stabilize-compass-per-timestamp branch October 10, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants