-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table sorting in descending order #7863
Conversation
…in the same order and not accidentally reverse them while inserting.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7863 +/- ##
==========================================
- Coverage 57.59% 57.45% -0.15%
==========================================
Files 675 675
Lines 27317 27317
Branches 2673 2673
==========================================
- Hits 15734 15694 -40
- Misses 11247 11287 +40
Partials 336 336
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -150,13 +150,13 @@ export default class TableRowCollection extends EventEmitter { | |||
} | |||
|
|||
insertOrUpdateRows(rowsToAdd, addToBeginning) { | |||
rowsToAdd.forEach((row) => { | |||
rowsToAdd.forEach((row, addRowsIndex) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it, smort. 🤓👈
Tested locally and it looks good to me, thanks! |
Have filed a followup for a test - #7870 |
Closes VIPERGC-643
Describe your changes:
When adding sorted arrays to the beginning of the table rows, make sure to insert them in the order of occurrence and not accidentally reverse them (by using unshift) while inserting.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist