-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't change sort order when changing performance mode #7810
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7810 +/- ##
=======================================
Coverage 56.96% 56.97%
=======================================
Files 674 675 +1
Lines 27281 27284 +3
Branches 2671 2671
=======================================
+ Hits 15540 15544 +4
+ Misses 11402 11401 -1
Partials 339 339
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #7809
Describe your changes:
Modified the
addTelemetryObject
method to NOT swap the sort order of the request and to default to any set order or descending.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist