Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change sort order when changing performance mode #7810

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Aug 9, 2024

Closes #7809

Describe your changes:

Modified the addTelemetryObject method to NOT swap the sort order of the request and to default to any set order or descending.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.97%. Comparing base (440474b) to head (0edec51).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ugins/telemetryTable/components/TableComponent.vue 11.11% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7810   +/-   ##
=======================================
  Coverage   56.96%   56.97%           
=======================================
  Files         674      675    +1     
  Lines       27281    27284    +3     
  Branches     2671     2671           
=======================================
+ Hits        15540    15544    +4     
+ Misses      11402    11401    -1     
  Partials      339      339           
Flag Coverage Δ
e2e-ci 61.79% <100.00%> (+0.02%) ⬆️
e2e-full 23.51% <28.57%> (+0.01%) ⬆️
unit 49.34% <47.05%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
src/plugins/telemetryTable/TelemetryTable.js 82.92% <100.00%> (ø)
src/plugins/telemetryTable/TelemetryTableType.js 100.00% <ø> (ø)
...s/telemetryTable/collections/TableRowCollection.js 63.94% <100.00%> (ø)
...telemetryTable/components/TableFooterIndicator.vue 28.57% <100.00%> (ø)
src/plugins/telemetryTable/constants.js 100.00% <100.00%> (ø)
src/plugins/telemetryTable/plugin.js 100.00% <ø> (ø)
...ugins/telemetryTable/components/TableComponent.vue 44.12% <11.11%> (-0.11%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440474b...0edec51. Read the comment docs.

@ozyx ozyx added this to the Target:4.0.1 milestone Aug 9, 2024
@jvigliotta jvigliotta requested a review from ozyx September 5, 2024 00:25
@unlikelyzero unlikelyzero enabled auto-merge (squash) September 6, 2024 01:58
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 10, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 10, 2024
@unlikelyzero unlikelyzero merged commit fccae3b into master Sep 10, 2024
38 checks passed
@unlikelyzero unlikelyzero deleted the mode-sort-fix branch September 10, 2024 02:28
davetsay added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry TABLES!] Changing performance mode changes sort order of request unexpectedly
5 participants