Split Deframer into FrameAccumulator and Router #2900
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| class CRCWrapper { | ||
| protected: | ||
| //! \brief constructor setting initial value | ||
| CRCWrapper(TokenType initial) : m_crc(initial) {} |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
thomas-bc
added
the
Update Instructions Needed
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| class CRCWrapper { | ||
| protected: | ||
| //! \brief constructor setting initial value | ||
| CRCWrapper(TokenType initial) : m_crc(initial) {} |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit.
thomas-bc
changed the title
|
Will fix #2073 |
|
@thomas-bc @LeStarch I made a fork and kinda ran with it in my repo I found what I think is an issue with the frame detection here Currently I'm workin to fix my TM framer impl but let me know if I'm stepping on anyones toes or going in a bad direction |
Change Description
Split up Deframer into 3 components:
UplinkRouter?)Using this new structure, adding in 2 new deframers for CCSDS SpacePacket and TM protocols.
Rationale
Better reusability and chaining of deframers, preliminary work for CCSDS integrations
TODO
!!! Unit tests, SDDs, update documentation
!!! UPDATE
fprime-util new --deployment