Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier local setup of mrfgen tools #185

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Conversation

zmoon
Copy link
Contributor

@zmoon zmoon commented Sep 12, 2024

The main change is the addition of a Conda env spec and some edits to the mrfgen readme.

I also wrote a small install script and made some minor changes in order for --help to work without error for all of the tools. src/mrfgen/RgbPngToPalPng.py had some \rs in it, I ran dos2unix on it to get it to work as an executable. I also linked oe_utils.py since it's needed.

I wasn't able to get all the same versions from conda-forge as pinned elsewhere, so open to thoughts about that.

env was unsolvable as it was, the gdal pin restricting
to earlier pillow/rasterio

rasterio 1.3.10 wanted gdal 3.9

with the current gdal pin, I got
- pillow 10.0.0
- rasterio 1.3.7
the install info doesn't need to be in separate file
and wouldn't work anyway since there is no requirements.txt
in this directory

the example at the end also doesn't seem to exist anymore
@jtroberts
Copy link
Member

Thanks for the contribution! We'll run some test with GIBS to make sure our builds are happy.

We've had some prior discussions about making mrfgen its own standalone repository. I'd be interested to hear if that would be a worthwhile pursuit.

@zmoon
Copy link
Contributor Author

zmoon commented Sep 18, 2024

making mrfgen its own standalone repository

Yes I did also think about this. It would be convenient if it had a conda-forge recipe, say. And that would be much easier to set up if mrfgen had its own repo.

I was also curious about the status of https://github.com/nasa-gibs/gpu-data-to-image

@jtroberts
Copy link
Member

I was also curious about the status of https://github.com/nasa-gibs/gpu-data-to-image

It was intended as a prototype and has been dormant for a few years. It worked great back then and could be revived. We wanted to integrate it with https://github.com/apache/sdap-nexus but never had the cycles to put things together.

Copy link
Collaborator

@grabermtw grabermtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@grabermtw grabermtw merged commit 6ca9fe8 into nasa-gibs:main Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants