Add typing checks to ui #45
Conversation
goanpeca
commented
Nov 29, 2022
•
goanpeca
commented
- Add a bit of typing
- Add typing checks
- Fix resource loading
|
Thanks for the comments @dalthviz, will fix them! |
| @@ -4,6 +4,8 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
| paths: | |||
| - 'build_installers.py' | |||
There was a problem hiding this comment.
Curious about the rationale behind constraining the runs to this file only. otherwise PR lgtm
There was a problem hiding this comment.
Hi @potating-potato, so we do not want to trigger a bundle build unless something changed in the file in charge of creating the bundles. I added this on this PR to make the other PRs simpler.
constructor-manager-ui/src/constructor_manager_ui/style/utils.py
Outdated
Show resolved
Hide resolved
| # Generate resources file from QRC file | ||
| print("Generating resources file from QRC file...") | ||
| check_call(["pyrcc5", "images.qrc", "-o", "images.py"], cwd=CWD) |
There was a problem hiding this comment.
So there is the assumption that it will be built using PyQt5? What with PyQt6? PySide[2|6]?
There was a problem hiding this comment.
For now, but will update in a separate PR to use the correct binding found.
There was a problem hiding this comment.
Could we add a TODO or FIXME here in that case?
There was a problem hiding this comment.
Created this issue #47
There was a problem hiding this comment.
Added a todo also ;)
