Attempt to fix failing CI tests #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx docs
Temporary fix for issue imageio/imageio-ffmpeg#71
…tforms it won't run on)
…test arm64 runner.
…s for mac arm64 not available via imageio[ffmpeg] plugin
GenevieveBuckley
changed the title
GenevieveBuckley
commented
Jun 4, 2024
| include_package_data = True | ||
| install_requires = | ||
| imageio | ||
| imageio-ffmpeg | ||
| imageio[ffmpeg] |
There was a problem hiding this comment.
This should be functionally equivalent, but fewer CI jobs failed when imageio & ffmpeg were installed as a single step.
…le Silicon macos arm64
…y on Apple Silicon macos arm64" This reverts commit 1c3684b.
|
Turns out you can run the PySide tests on Windows (possibly the napari discussion was a bit confused by the fact PySide requires python<=3.10). Fixes here: #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pip install imageio[ffmpeg]also does not include the ffmpeg binary for Apple Silicon mac (but imageio can still work if you install ffmpeg separately)napari is experiencing CI failures with PySide backends
on Windows platforms for all versions of python,
and on all platforms with python greater than 3.10.
Also, PySide2 is not currently available for macos arm-64 machines.
Python 3.11 PySide problems:
Windows PySide problems:
Previously: