trial to fix winipc crash

[gdamore]

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

[gdamore]

This is just a trial balloon.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (d3652db) to head (b7298cf).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
- Coverage   79.77%   78.13%   -1.64%     
==========================================
  Files          95       93       -2     
  Lines       21628    20986     -642     
==========================================
- Hits        17253    16398     -855     
- Misses       4375     4588     +213     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gdamore]

This PR is an attempt to fix #1837 -- I don't know if it will actually do the trick. But it passed at least the first round of tests.

[itayzafrir]

Hi @gdamore I tested this change on a Windows (virtual) machine & very happy to say that the use after free did not reproduce. Looks like you fixed it 👍

[alzix]

@gdamore, are you merging this PR?

[gdamore]

Not precisely as is.  But something close to it • Garrett

…

On Jul 30, 2024 at 2:04 AM -0700, Alexander Zilberkant ***@***.***>, wrote: @gdamore, are you merging this PR? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[gdamore]

This had an WSS failure on close, which makes me thing we haven't really found them all. I am thinking I need to take a similar approach for the connect() and accept() calls. I'd appreciate any further results from folks testing.