Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uftrace: Fix segfault when given logfile name is already taken by a directory #861

Merged
merged 1 commit into from
Sep 9, 2019
Merged

uftrace: Fix segfault when given logfile name is already taken by a directory #861

merged 1 commit into from
Sep 9, 2019

Conversation

rls1004
Copy link
Contributor

@rls1004 rls1004 commented Sep 9, 2019

This patch is to fix segfault in --logfile.
If logfd is NULL, set logfd to stderr before calling pr_err().

Fixed: #853

@rls1004 rls1004 changed the title uftrace: ix segfault when --logfile uftrace: Fix segfault when given logfile name is already taken by a directory Sep 9, 2019
@honggyukim
Copy link
Collaborator

Thanks for the fix. Could you please add Signed-off-by statement at the end of the commit message? You can simply run git amend -s to add it. And please also make sure your real name is updated in ~/.gitignore.

@honggyukim
Copy link
Collaborator

honggyukim commented Sep 9, 2019 •
edited
Loading

The first line of commit message is better to be less than 50 characters.

@rls1004
Copy link
Contributor Author

rls1004 commented Sep 9, 2019

Did you mean ~/.gitconfig, not ~/.gitignore?

@rls1004
uftrace: Fix segfault when using --logfile
371ea19 
This patch is to fix segfault in --logfile.
If logfd is NULL, set logfd to stderr before calling pr_err().

Fixed: namhyung#853

Signed-off-by: MinJeong Kim <[email protected]>
@honggyukim
Copy link
Collaborator

Right. I mean ~/.gitconfig.

honggyukim
honggyukim approved these changes Sep 9, 2019
View reviewed changes
Copy link
Collaborator

@honggyukim honggyukim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

namhyung
namhyung approved these changes Sep 9, 2019
View reviewed changes
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@namhyung namhyung merged commit a9ef15c into namhyung:master Sep 9, 2019
@rls1004 rls1004 mentioned this pull request Oct 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honggyukim honggyukim honggyukim approved these changes

@namhyung namhyung namhyung approved these changes

Assignees
No one assigned
Labels
contributon2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault when given logfile name is already taken by a directory
3 participants
@rls1004 @honggyukim @namhyung