Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Revision Controller #1031

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

[WIP] Revision Controller #1031

wants to merge 20 commits into from

Conversation

gmichelo
Copy link
Contributor

No description provided.

@gmichelo
Copy link
Contributor Author

gmichelo commented Dec 22, 2022 •
edited
Loading

TODO list (not in order of priority):

  • Autogenerate CRD deepcopy.go files and YAML manifests, as one would do with kubebuilder (example of makefile). As of now, CRD YAML manifest and deepcopy functions are manually written.
  • Access to image registry is set insecure to make it work with local image registry. Find proper fix.
  • Image link must use the local image registry's internal port (i.e. 5000) rather than externally exposed port (e.g. 57321). Possible solution: on-the-fly automatic rewrites?
  • Implement undeploy/cancellation use-case. Orchestrator gRPC server needs to implement an undeploy method.
  • Set ownership-ref for K8s objects created by Orchestrator.
  • Properties in Revision.Status? User might want to know the deployment ID to refer to it later
  • Set events on Revision object
  • Add code comments
  • User documentation
  • Automate IAM Service Account creation for Orchestrator (follow these instructions)

@gmichelo gmichelo changed the title [WIP] Controller skeleton + CRD definition [WIP] Revision Controller Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gmichelo