-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support batchRegisterInstance of nacos2.x for develop branch #336
base: develop
Are you sure you want to change the base?
Conversation
pom.xml
Outdated
<spring-boot.version>2.5.14</spring-boot.version> | ||
<spring-cloud.version>2020.0.2</spring-cloud.version> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<zookeeper.version>3.4.9</zookeeper.version> | ||
<curator.version>4.1.0</curator.version> | ||
<mockito.version>1.10.19</mockito.version> | ||
<nacos-client.verison>1.4.2</nacos-client.verison> | ||
<nacos-client.verison>2.3.0</nacos-client.verison> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading from 1.4.2 to 2.3.0 will result in compatibility issues with 1.x cluster synchronization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only nacos client 2.x provided batch registration interfaces, so this version only support nacos2.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we suggest use a new branch for nacos 2.x support, e.g. nacos-2.x to support nacos 2.x client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we suggest use a new branch for nacos 2.x support, e.g. nacos-2.x to support nacos 2.x client.
i don't have permission to create a new branch.
Can we add configuration synchronization to support Dubbo meta migration? |
maybe this pr is just meeting our needs. you might provide a new PR for configuration synchronization? |
7a17358
to
59e0c31
Compare
try to fix #307 at develop branch