Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error on missing source #13

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

jfrconley
Copy link
Contributor

Currently, the transformer errors out if source files are missing for a scanned call expression. This usually happens due to another transformer running first. The issue is that the source file information is used to verify that the node is from this library.

Instead of using source file info to determine locality, we should now use a JSDoc tag marker.

@jfrconley jfrconley requested a review from a team as a code owner August 8, 2023 02:39
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 21b49fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nrfcloud/ts-json-schema-transformer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 2.3% 11/479
🔴 Branches 0.74% 2/269
🔴 Functions 2.78% 2/72
🔴 Lines 2.19% 10/456

Test suite run success

27 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 21b49fd

@jfrconley jfrconley merged commit 29cb6ec into main Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant