feat: address delete

n9mi · Sep 17, 2024 · 055cef4 · 055cef4
1 parent 6e422bd
commit 055cef4
Show file tree

Hide file tree

Showing 4 changed files with 106 additions and 4 deletions.
diff --git a/__tests__/address.spec.ts b/__tests__/address.spec.ts
@@ -149,7 +149,7 @@ describe("POST /contacts/:contactId/addresses", () => {
     });
 });
 
-describe("POST /contacts/:contactId/addresses", () => {
+describe("PUT /contacts/:contactId/addresses/:addressId", () => {
     let token: string = "";
     let contact: Contact = {} as Contact;
     let address: Address = {} as Address;
@@ -263,6 +263,54 @@ describe("POST /contacts/:contactId/addresses", () => {
     });
 });
 
+describe("DELETE /contacts/:contactId/addresses/:addressId", () => {
+    let token: string = "";
+    let contact: Contact = {} as Contact;
+    let address: Address = {} as Address;
+
+    beforeAll(async () => {
+        token = await AddressTestUtil.getToken();
+        contact = await AddressTestUtil.createContact();
+        address = await AddressTestUtil.createAddress(contact.id);
+    });
+
+    afterAll(async () => {
+        await AddressTestUtil.deleteAddress();
+        await AddressTestUtil.deleteContact();
+        await AddressTestUtil.deleteUser();
+    });
+
+    it("should return 200 - success deleting an address", async () => {
+        const res = await supertest(web)
+            .delete(`${basePath}/contacts/${contact.id}/addresses/${address.id}`)
+            .set('Authorization', `Bearer ${token}`);
+
+        logger.info(res.body);
+        expect(res.status).toBe(200);
+        expect(res.body.status).toBe(true);
+    });
+
+    it("should return 404 - contact doesn't exists", async () => {
+        const res = await supertest(web)
+            .delete(`${basePath}/contacts/${1000}/addresses/${address.id}`)
+            .set('Authorization', `Bearer ${token}`);
+
+        logger.info(res.body);
+        expect(res.status).toBe(404);
+        expect(res.body.errors).toBeDefined();
+    });
+
+    it("should return 404 - address doesn't exists", async () => {
+        const res = await supertest(web)
+            .delete(`${basePath}/contacts/${contact.id}/addresses/${1000}`)
+            .set('Authorization', `Bearer ${token}`);
+
+        logger.info(res.body);
+        expect(res.status).toBe(404);
+        expect(res.body.errors).toBeDefined();
+    });
+})
+
 class AddressTestUtil {
     static user = {
         name: "user_test_address",

diff --git a/src/controller/address.ts b/src/controller/address.ts
@@ -35,7 +35,7 @@ export class AddressController {
 
             const createRes = await AddressService.create(res.locals.user.usename, contactId, createReq);
 
-            return res.status(200)
+            res.status(200)
                 .json({
                     data: createRes
                 });
@@ -50,7 +50,7 @@ export class AddressController {
                 throw new ResponseError(404, "contact doesn't exists");
             }
             if (isNaN(Number(req.params.addressId)) || Number(req.params.addressId) < 1) {
-                throw new ResponseError(404, "contact doesn't exists");
+                throw new ResponseError(404, "address doesn't exists");
             }
 
             const updateReq = req.body as AddressRequest;
@@ -59,12 +59,34 @@ export class AddressController {
 
             const updateRes = await AddressService.update(res.locals.user.usename, contactId, addressId, updateReq);
 
-            return res.status(200)
+            res.status(200)
                 .json({
                     data: updateRes
                 });
         } catch (e) {
             next(e);
         }
     }
+
+    static async delete(req: Request, res: Response, next: NextFunction) {
+        try {
+            if (isNaN(Number(req.params.contactId)) || Number(req.params.contactId) < 1) {
+                throw new ResponseError(404, "contact doesn't exists");
+            }
+            if (isNaN(Number(req.params.addressId)) || Number(req.params.addressId) < 1) {
+                throw new ResponseError(404, "address doesn't exists");
+            }
+            const contactId = Number(req.params.contactId);
+            const addressId = Number(req.params.addressId);
+
+            const deleteRes = await AddressService.delete(res.locals.user.username, contactId, addressId);
+
+            res.status(200)
+                .json({
+                    status: deleteRes
+                });
+        } catch (e) {
+            next(e);
+        }
+    }
 }
diff --git a/src/router/address.ts b/src/router/address.ts
@@ -8,6 +8,7 @@ export const getAddressRouter = (basePath: string) => {
     addressRouter.get(`${basePath}/contacts/:contactId/addresses`, AddressController.getAll);
     addressRouter.post(`${basePath}/contacts/:contactId/addresses`, AddressController.create);
     addressRouter.put(`${basePath}/contacts/:contactId/addresses/:addressId`, AddressController.update);
+    addressRouter.delete(`${basePath}/contacts/:contactId/addresses/:addressId`, AddressController.delete);
 
     return addressRouter;
 }
diff --git a/src/service/address.ts b/src/service/address.ts
@@ -100,4 +100,35 @@ export default class AddressService {
 
         return toAddressResponse(address);
     }
+
+    static async delete(username: string, contactId: number, addressId: number): Promise<boolean> {
+        const isContactExists = await prisma.contact.count({
+            where: {
+                id: contactId,
+                username: username
+            }
+        }) === 1;
+        if (!isContactExists) {
+            throw new ResponseError(404, "contact doesn't exists");
+        }
+
+        const isAddressExists = await prisma.address.count({
+            where: {
+                id: addressId,
+                contact_id: contactId,
+            }
+        }) === 1;
+        if (!isAddressExists) {
+            throw new ResponseError(404, "address doesn't exists");
+        }
+
+        await prisma.address.delete({
+            where: {
+                id: addressId,
+                contact_id: contactId,
+            }
+        });
+
+        return true;
+    }
 }